Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Witness: Rename "Town Windmill Entry" to "Windmill Entry" #3081

Merged
merged 3 commits into from
Apr 14, 2024
Merged

The Witness: Rename "Town Windmill Entry" to "Windmill Entry" #3081

merged 3 commits into from
Apr 14, 2024

Conversation

NewSoupVi
Copy link
Member

@NewSoupVi NewSoupVi commented Apr 2, 2024 •
edited
Loading

Windmill is no longer considered a part of Town since the area_hints PR. Also, all "Entry" doors have been renamed last update to only contain the place they are an Entry to. This one slipped through the cracks. Oh well, it happens

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Apr 2, 2024
@NewSoupVi NewSoupVi added the is: refactor/cleanup Improvements to code/output readability or organizization. label Apr 2, 2024
ScipioWright
ScipioWright approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@ScipioWright ScipioWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It functions, and this review will hopefully not get my account suspended.

@Exempt-Medic
Copy link
Collaborator

Will fixing "Challenge Tunnels Entry (Door)" ( to remove Challenge ) and "Swamp Platform Shortcut Door" ( to use (Door) ) be another PR?

@NewSoupVi
Copy link
Member Author

Will fixing "Challenge Tunnels Entry (Door)" ( to remove Challenge ) and "Swamp Platform Shortcut Door" ( to use (Door) ) be another PR?

Yeah

Exempt-Medic
Exempt-Medic approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally through generations and reading spoiler logs.

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 5, 2024
@NewSoupVi
Copy link
Member Author

This PR will likely conflict with #3007, which I absolutely need to be merged before anything else, so I'm putting this one on "waiting on: other".

@NewSoupVi NewSoupVi added waiting-on: other Issue/PR is waiting for something else, like another PR. and removed waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. labels Apr 7, 2024
@Exempt-Medic Exempt-Medic added waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. and removed waiting-on: other Issue/PR is waiting for something else, like another PR. labels Apr 11, 2024
@NewSoupVi NewSoupVi added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: author Issue/PR is waiting for feedback or changes from its author. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Apr 11, 2024
@Berserker66 Berserker66 merged commit 9ef1fa8 into ArchipelagoMW:main Apr 14, 2024
10 checks passed
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@NewSoupVi @EmilyV99
The Witness: Rename "Town Windmill Entry" to "Windmill Entry" (Archip…
12f480d 
…elagoMW#3081)
EmilyV99 pushed a commit to EmilyV99/Archipelago that referenced this pull request Apr 15, 2024
@NewSoupVi @EmilyV99
The Witness: Rename "Town Windmill Entry" to "Windmill Entry" (Archip…
cef86b4 
…elagoMW#3081)
qwint pushed a commit to qwint/Archipelago that referenced this pull request Jun 24, 2024
@NewSoupVi @qwint
The Witness: Rename "Town Windmill Entry" to "Windmill Entry" (Archip…
ce636f0 
…elagoMW#3081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

@ScipioWright ScipioWright ScipioWright approved these changes

@Berserker66 Berserker66 Berserker66 approved these changes

Assignees
No one assigned
Labels
is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NewSoupVi @Exempt-Medic @Berserker66 @ScipioWright